Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: allow adding custom Vary to static assets handler #2835

Merged
merged 7 commits into from
Nov 5, 2024
Merged

fix: allow adding custom Vary to static assets handler #2835

merged 7 commits into from
Nov 5, 2024

Conversation

daniluk4000
Copy link
Contributor

🔗 Linked issue

Closes #2834

❓ Type of change

  • 📖 Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Allow to auto-extend Vary header if Accept-Encoding is passed from Nitro.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@daniluk4000 daniluk4000 requested a review from pi0 as a code owner November 2, 2024 13:29
@daniluk4000 daniluk4000 changed the title feat: allow custom Vary header feat: allow custom static Vary header Nov 2, 2024
@pi0 pi0 changed the title feat: allow custom static Vary header feat: allow addinng custom Vary to static assets header Nov 2, 2024
@daniluk4000 daniluk4000 requested a review from pi0 November 4, 2024 12:30
@daniluk4000 daniluk4000 changed the title feat: allow addinng custom Vary to static assets header feat: allow adding custom Vary to static assets header Nov 4, 2024
@autofix-troubleshooter
Copy link

Hi! I'm the autofix logoautofix.ci troubleshooter bot.

It looks like you correctly set up a CI job that uses the autofix.ci GitHub Action, but the autofix.ci GitHub App has not been installed for this repository. This means that autofix.ci unfortunately does not have the permissions to fix this pull request. If you are the repository owner, please install the app and then restart the CI workflow! 😃

pi0
pi0 reviewed Nov 4, 2024
View reviewed changes
test/tests.ts Outdated Show resolved Hide resolved
@daniluk4000
Copy link
Contributor Author

I sadly do not know locally what Prettier wants from me

@pi0 pi0 changed the title feat: allow adding custom Vary to static assets header fix: allow adding custom Vary to static assets handler Nov 5, 2024
@pi0 pi0 merged commit 11ec5ba into nitrojs:v2 Nov 5, 2024
4 checks passed
@pi0
Copy link
Member

pi0 commented Nov 5, 2024

Thnx!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pi0 pi0 pi0 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow adding custom vary header for static assets
3 participants
@daniluk4000 @autofix-troubleshooter @pi0